Abort iteration when fs-event-incapable #2867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nvim-tree#2866. The original code, while detecting whether Windows NT allows the dir to be iterated through, will go to the other branch of the if...else... statement, which is intended for cases when filter_reason is not none. Simply moving `is_fs_event_capable` into the first branch should solve the problem.
alex-courtis
requested changes
Aug 17, 2024
| if link.link_to ~= nil then | ||
| child = link | ||
| if filter_reason == FILTER_REASON.none and not nodes_by_path[abs] then | ||
| if Watcher.is_fs_event_capable(abs) then |
There was a problem hiding this comment.
This will be a change in behaviour for all users; unfortunately we can't do that.
| if child then | ||
| table.insert(node.nodes, child) | ||
| nodes_by_path[child.absolute_path] = true | ||
| explorer_node.update_git_status(child, node_ignored, git_status) | ||
| end | ||
| else |
There was a problem hiding this comment.
This was added recently and appears it will execute despite is_fs_event_capable fail.
I reckon we should wrap that test around the whole block, something like:
local abs = utils.path_join { cwd, name }
if Watcher.is_fs_event_capable(abs) thenDefering to @evertonse on this one :)
There was a problem hiding this comment.
We could live dangerously and optimise this a little, only testing when t == "directory" as per:
This was referenced Aug 17, 2024
|
Superceded by #2874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2866. The original code, while detecting whether Windows NT allows the dir to be iterated through, will go to the other branch of the if...else... statement, which is intended for cases when filter_reason is not none. Simply moving
is_fs_event_capableinto the first branch should solve the problem.